Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on improved hand menu + improved subsystem query API #10852

Closed
wants to merge 42 commits into from
Closed

Work on improved hand menu + improved subsystem query API #10852

wants to merge 42 commits into from

Conversation

Zee2
Copy link
Contributor

@Zee2 Zee2 commented Aug 9, 2022 •
edited
Loading

Overview

This introduces an improved hand menu script that is completely independent of the solvers/constraints system, and offers much improved visual polish + responsiveness.

handmenu

  • Improve our subsystem query API to cache and reuse scratch lists for alloc-free every-frame-queries
  • "Flipping"-style flip-up effect
  • Dynamic anchoring of Canvas content
  • Dampening movement when opposite hand is near
  • Switching menu between hands
  • Require open hand
  • Require FOV cone
  • Gaze integration
  • Work with controllers
  • Port existing hand menu UI prefabs to use the new hand menu script

Changes

  • Fixes: HandConstraintPalmUp has issues + glitches #10811 , Quest 2 HandConstraintPalmUp has issues throughout all example scenes #10848 , etc by no longer using HandConstraintPalmUp for hand menus
  • Improves GrabBar material for fading/smoothing
  • Adds implicit cast operator for HandJointPose to Pose
  • Adds TransformPose(Pose pose) method to PlayspaceUtilities
  • Adds IsShowingHands getter to RiggedHandMeshVisualizer
  • Adds HandMenu.cs, a standalone, dedicated hand menu script
  • Refactors some of our XRSubsystemHelpers to cache based on type for improved memory allocation behavior
  • Adds hand mesh enable/disable to our sample scene hand menu

@Zee2 Zee2 self-assigned this Aug 9, 2022
Zee2 added 20 commits August 10, 2022 11:43
@Zee2
Merge branch 'mrtk3' into new_hand_menu
be5d790
@Zee2
Merge branch 'mrtk3' into new_hand_menu
fdc646d
@Zee2
Merge branch 'mrtk3' into new_hand_menu
5a5f332
@Zee2
Hand menu improvements
68e864c
@Zee2
Button disabled effects fixes
9ee4ac9
@Zee2
Update hand menu prefab + grab bar material
8c12efc
@Zee2
New API for RHMV
7fdb5ee
@Zee2
Hand mesh settings on the hand menu
ab5ef15
@Zee2
Merge branch 'mrtk3' into new_hand_menu
348ec81
@Zee2
Merge branch 'mrtk3' into new_hand_menu
f4b3a6b
@Zee2
FOV-based activation + polish
ada7e85
@Zee2
Merge branch 'new_hand_menu' of https://github.com/Zee2/MixedRealityT…
f47a69a 
…oolkit-Unity into new_hand_menu
@Zee2
Merge branch 'mrtk3' into new_hand_menu
40f10ae
@Zee2
Hand menu prefab update
2fb4de7
@Zee2
Fixing incorrect transition time + missing font icon reference in dis…
7c288ab 
…able effect
@Zee2
Merge branch 'button_disable_effect_fix' into new_hand_menu
ee2ce10
@Zee2
Syncing with other branch's stateviz changes
de7136a
@Zee2
Adding implicit cast operator to HandJointPose
a13f0aa
@Zee2
Adding TransformPose to PlayspaceUtilities
9e6c562
@Zee2
More improvements to HandMenu
225e26c
@Zee2 Zee2 added this to the MRTK3 milestone Aug 25, 2022
@Zee2 Zee2 mentioned this pull request Aug 31, 2022
Closed
@Zee2 Zee2 mentioned this pull request Oct 10, 2022
Closed
@AMollis
Copy link
Member

AMollis commented Jan 13, 2024

We appreciate your contribution and thank you for the pull request.

Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority issues. Unfortunately, this pull request does not meet the necessary priority and will be closed. If you strongly feel that this change deserves more attention, please open a new pull request and explain why it is important.

Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.

Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.

Thank you for your continued support of the Mixed Reality Toolkit!

@AMollis AMollis closed this Jan 13, 2024
@keveleigh
Copy link
Contributor

keveleigh commented Jan 13, 2024 •
edited
Loading

Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support.

@AMollis uhhhhhhhhhhhh this is an MRTK3 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keveleigh keveleigh Awaiting requested review from keveleigh

@david-c-kline david-c-kline Awaiting requested review from david-c-kline

@marlenaklein-msft marlenaklein-msft Awaiting requested review from marlenaklein-msft marlenaklein-msft will be requested when the pull request is marked ready for review marlenaklein-msft is a code owner

@AMollis AMollis Awaiting requested review from AMollis AMollis will be requested when the pull request is marked ready for review AMollis is a code owner

@shaynie shaynie Awaiting requested review from shaynie shaynie will be requested when the pull request is marked ready for review shaynie is a code owner

Assignees

@Zee2 Zee2

Labels
MRTK3 Subsystems UX Controls - Hand Menu
Projects
None yet
Milestone
MRTK v3.x future
Development

Successfully merging this pull request may close these issues.
3 participants
@Zee2 @AMollis @keveleigh